Closed
Bug 968849
Opened 12 years ago
Closed 12 years ago
Fix some XPCOM warnings
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(1 file, 1 obsolete file)
|
3.60 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
GCC warns about uninitialized variables.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8371537 -
Flags: review?(doug.turner)
|
||
Updated•12 years ago
|
Attachment #8371537 -
Flags: review?(doug.turner) → review?(nfroyd)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8371537 [details] [diff] [review]
Bug 968849: Fix GCC warnings about unintialized variables
Review of attachment 8371537 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the change below.
::: xpcom/tests/TestDeadlockDetector.cpp
@@ +167,5 @@
> len = 0;
> }
> else {
> NS_ERROR(PR_ErrorToName(PR_GetError()));
> + len = 0;
Instead of doing this, why don't we move |len| to be declared inside the for loop, and initialize len to 0. Then you can remove the assignment in the PR_POLL_HUP case.
Attachment #8371537 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Updated according to your review. Thanks.
Attachment #8371537 -
Attachment is obsolete: true
Attachment #8371574 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•