968872 - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #962101 +++

Created based on Bug 962101 Comment 18. After Bug 962101 is fixed, we could remove TEXTURE_DEALLOCATE_DEFERRED flag.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Comment 3

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8374077 [details] [diff] [review]
patch - Remove TEXTURE_DEALLOCATE_DEFERRED flag

clear review?. The patch seems to have a problem.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Fix TEXTURE_DEALLOCATE_CLIENT flag's handling.

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8374281 [details] [diff] [review]
patch v2 - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Review of attachment 8374281 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/TextureHost.cpp
@@ -734,3 @@
>    case Deletion:
> -    if (!(mTextureHost->GetFlags() & TEXTURE_DEALLOCATE_CLIENT) && !isDeffered) {
> -      mTextureHost->DeallocateSharedData();

Are you sure about removing this entirely? which code path will handle deallocating the shared data on the host side now?

Comment 6

[Sotaro Ikeda [:sotaro]]

> ::: gfx/layers/composite/TextureHost.cpp
> @@ -734,3 @@
> >    case Deletion:
> > -    if (!(mTextureHost->GetFlags() & TEXTURE_DEALLOCATE_CLIENT) && !isDeffered) {
> > -      mTextureHost->DeallocateSharedData();
> 
> Are you sure about removing this entirely? which code path will handle
> deallocating the shared data on the host side now?

Nical, in my understanding, TextureHost::Finalize() handle it if the TextureHost does not have TEXTURE_DEALLOCATE_CLIENT. Does it cause a problem?

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8374281 [details] [diff] [review]
patch v2 - Remove TEXTURE_DEALLOCATE_DEFERRED flag

Review of attachment 8374281 [details] [diff] [review]:
-----------------------------------------------------------------

Ah! Yes indeed, I got confused. This code as been moving around so many times.

Comment 8

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=344dace5e811

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch v3 - Remove TEXTURE_DEALLOCATE_DEFERRED flag (r=nical)

Committable patch. Carry "r=nical".

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/924c9e7d32f2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/924c9e7d32f2