968892 - Typo in romanized name for China

Status: RESOLVED FIXED

(Core Graveyard :: Networking: Domain Lists, defect)

Description

[Gervase Markham [:gerv]]

1.136 -// xn--fiqs8s ("China" Chinese-Han-Simplified <.Zhonggou>) : CN
   1.137 +// xn--fiqs8s ("China" Chinese-Han-Simplified <.Zhonggou>) : CN
   1.138  // CNNIC
   1.139  // http://cnnic.cn/html/Dir/2005/10/11/3218.htm
   1.140  中国
   1.141
   1.142  // xn--fiqz9s ("China" Chinese-Han-Traditional <.Zhonggou>) : CN
   1.143  // CNNIC
   1.144  // http://cnnic.cn/html/Dir/2005/10/11/3218.htm
   1.145  中國


China is Zhongguo (Zhong = Center, Guo = Country) not Zhonggou

Gerv

Comment 1

[Zack Weinberg (:zwol)]

Your -+ lines don't appear to change anything?  Also note that the same typo appears on line 142 just below.

Comment 2

[Zack Weinberg (:zwol)]

(ignore first sentence of previous comment, please, I see now that was a direct quote from the original reporter)

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Two-line typo fix.

Gerv

Comment 4

[Simone Carletti]

I checked the patch and it looks fine to me. There are no other occurrences. I'm not sure what else I need to do in this case, it's my first review. :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf4ff022253

BTW, you may want to check your Hg config, Gerv. The diff you attached wasn't in the proper format.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aaf4ff022253