Closed Bug 968914 Opened 7 years ago Closed 7 years ago

Follow-up: Add unit tests for SIM Dialog Retry count

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: mikehenrty, Unassigned)

References

Details

(Whiteboard: [systemsfe][ETA:2/6])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #966571 +++

We need to add integration tests for the fix in 966571.
Attached file Added unit tests
Francisco,

This will need to be re-run on travis once bug 966571 lands, but I wanted to get the ball rolling on your review in the meantime if possible.
Attachment #8371613 - Flags: review?(francisco.jordano)
Comment on attachment 8371613 [details] [review]
Added unit tests

Hi!

Thanks for the unit tests!

Just left a message in github to try to reduce the number of lines of the patch, perhaps using the setup and teardown methods of the suite.

Flag me again if it's not possible to implement :), a part from that the PR is looking great!
Attachment #8371613 - Flags: review?(francisco.jordano)
Target Milestone: --- → 1.4 S1 (14feb)
Comment on attachment 8371613 [details] [review]
Added unit tests

Addressed you comments.
Attachment #8371613 - Flags: review?(francisco.jordano)
Comment on attachment 8371613 [details] [review]
Added unit tests

Awesome work!

Will land the patch since today is holidays in US :)
Attachment #8371613 - Flags: review?(francisco.jordano) → review+
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/ca9fa63953b2fc8a4fdeb9a5bc09cf0f31944f3b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.