968914 - Follow-up: Add unit tests for SIM Dialog Retry count

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

+++ This bug was initially created as a clone of Bug #966571 +++

We need to add integration tests for the fix in 966571.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Added unit tests

Francisco,

This will need to be re-run on travis once bug 966571 lands, but I wanted to get the ball rolling on your review in the meantime if possible.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8371613 [details] [review]
Added unit tests

Hi!

Thanks for the unit tests!

Just left a message in github to try to reduce the number of lines of the patch, perhaps using the setup and teardown methods of the suite.

Flag me again if it's not possible to implement :), a part from that the PR is looking great!

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8371613 [details] [review]
Added unit tests

Addressed you comments.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8371613 [details] [review]
Added unit tests

Awesome work!

Will land the patch since today is holidays in US :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/ca9fa63953b2fc8a4fdeb9a5bc09cf0f31944f3b