Closed
Bug 968917
Opened 10 years ago
Closed 10 years ago
[Contacts][l12y] Fix concatenated string simNumber with : character
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: theo, Assigned: ferjm)
References
Details
Attachments
(1 file)
The string simNumber is concatenated with :, and it should not. See https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/utilities/sim_dom_generator.js#L14 The string simNumber = SIM {{number}} Should rather be: simNumber = SIM {{number}}:
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Comment 1•10 years ago
|
||
IIRC We need to change the string id so people know that the string changed
Attachment #8539205 -
Flags: review?(francisco)
|
||
Updated•10 years ago
|
Attachment #8539205 -
Flags: review?(francisco) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/17b0cf9691ff70ee02b1254691351d6b63086c03
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•