968924 - Add shapes to network status bubbles

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Currently the netmonitor status bubbles are all colored circles. We should add some variety to those to make them easier to distinguish.

I'm thinking of adding circles, triangles, squares, and octagons.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Can we just add the status code? It's very frustrating for me as a color blind person. Shapes would help some, but I really just want the status code.

Comment 2

[Rob Campbell [:rc] (:robcee)]

that's why I'm adding shapes!

Comment 3

[Rob Campbell [:rc] (:robcee)]

Attachment: shapes

Comment 4

[Rob Campbell [:rc] (:robcee)]

Attachment: Screen Shot.png

not pictured: the diamond! (500 - server errors)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/47f971e754b6

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/47f971e754b6

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8371697 [details] [diff] [review]
shapes

[Approval Request Comment]
Bug caused by (feature/regressing bug #): circles
User impact if declined: users will be denied alternative polygons
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): negligible. Style changes only.
String or IDL/UUID changes made by this patch: nada

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cae2cfa89583