bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

make SizeTyped constructors MOZ_CONSTEXPR to avoid static constructors

RESOLVED FIXED in mozilla30

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla30
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 8371635 [details] [diff] [review]
make SizeTyped constructors MOZ_CONSTEXPR to avoid static constructors

This is similar to what has already been done for IntSizeTyped.
Attachment #8371635 - Flags: review?(bugmail.mozilla)
(Assignee)

Updated

5 years ago
Assignee: nobody → nfroyd
Comment on attachment 8371635 [details] [diff] [review]
make SizeTyped constructors MOZ_CONSTEXPR to avoid static constructors

Review of attachment 8371635 [details] [diff] [review]:
-----------------------------------------------------------------

Should the PointTyped and IntPointTyped constructors be doing this too? One of the IntPointTyped constructors already does it but the rest don't.
Attachment #8371635 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> Should the PointTyped and IntPointTyped constructors be doing this too? One
> of the IntPointTyped constructors already does it but the rest don't.

Yeah, probably so.  Want to see that patch?
Flags: needinfo?(bugmail.mozilla)
Rubber stamp! Assuming all our compilers are happy with it, I'm happy with it too.
Flags: needinfo?(bugmail.mozilla)
https://hg.mozilla.org/mozilla-central/rev/6165b393a420
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.