968972 - Firefox Accounts Button is Compressed in Customize with Overflow

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Button Shrinkage

If you have a lot of items in the Menu Panel causing a scrollbar when customizing, it shrinks the Firefox Accounts button in the footer.

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Prevent Shrinkage - 01

Sets flex-shrink to 0 on the #PanelUI-footer

Comment 2

[Stephen Horlander [:shorlander]]

Comment on attachment 8371685 [details] [diff] [review]
Prevent Shrinkage - 01

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 957460
User impact if declined: See a squished and illegible button
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low risk CSS change
String or IDL/UUID changes made by this patch: none

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/6a48babd4b20
https://hg.mozilla.org/releases/mozilla-aurora/rev/8746f092537a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a48babd4b20

Comment 5

[Cornel Ionce [:noni]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified issue as fixed on latest Aurora (build ID: 20140407004002) and on Firefox 29 beta 5 (build ID: 20140403132807).
The Firefox Accounts button is no longer compressed when the panel menu is overflowed.