Closed Bug 969038 Opened 7 years ago Closed 7 years ago

Backout bug 943924 now that setting a custom stack size on Windows works as expected

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

References

Details

Attachments

(1 file)

With bug 958796 fixed, using NSPR to create a thread with a custom stack size on Windows should now work as expected. As a result, the workaround from bug 943924 can be backed out. tp5o on Talos shows no regression from doing this:
http://compare-talos.mattn.ca/?oldRevs=208155fe186c&newRev=4ba604c8e19a&server=graphs.mozilla.org&submit=true
Attachment #8371753 - Flags: review?(bhackett1024) → review+
Green on try: https://tbpl.mozilla.org/?tree=Try&rev=1deb0b2ca446
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a961fb6594c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.