Closed
Bug 969038
Opened 10 years ago
Closed 10 years ago
Backout bug 943924 now that setting a custom stack size on Windows works as expected
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: ehoogeveen, Assigned: ehoogeveen)
References
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
With bug 958796 fixed, using NSPR to create a thread with a custom stack size on Windows should now work as expected. As a result, the workaround from bug 943924 can be backed out. tp5o on Talos shows no regression from doing this: http://compare-talos.mattn.ca/?oldRevs=208155fe186c&newRev=4ba604c8e19a&server=graphs.mozilla.org&submit=true
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8371753 -
Flags: review?(bhackett1024)
|
||
Updated•10 years ago
|
Attachment #8371753 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Green on try: https://tbpl.mozilla.org/?tree=Try&rev=1deb0b2ca446
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a961fb6594c0
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a961fb6594c0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•