Add URL and styling support to announcements

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: williamr, Assigned: giorgos)

Tracking

2014-02.2

Details

(Whiteboard: [kb=1268087] )

(Reporter)

Description

5 years ago
Some announcements on the site will point people to a link, and our current announcements do not support linking. I can also see use cases where it would be nice to bold, italicize or underline key words in an announcement.

Suggested markup to enhance announcements:
- URLs
- Bold
- Italics
- Underline

Markdown may be a good option.
(Assignee)

Comment 1

5 years ago
Announcements already support urls, bold and italics using html. 

Do you want:
 1. underline in this list?
 2. support for markdown?
(Assignee)

Comment 2

5 years ago
<hoosteeno> giorgos: re: https://bugzilla.mozilla.org/show_bug.cgi?id=969098#c1, williamr put an anchor tag in and it just showed up on the main screen. wasn't parsed.
<giorgos> hoosteeno, reproduced on stage. I'll have a look, thanks for the heads up
(Assignee)

Updated

5 years ago
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Whiteboard: [kb=1268087]
(Assignee)

Comment 3

5 years ago
OK I fixed it and added a test about it. Also enabled underline. pull request waits for review here.

https://github.com/mozilla/mozillians/pull/805

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/29b31bd84cf6607e6f7ef0c53447880f87ba4f8c
[fix bug 969098] Mark announcement text safe.

- Also added 'u' in allowed tags.

https://github.com/mozilla/mozillians/commit/30ecc8c156d1ee04e4b9cb4e6bcaa2f690ab8a98
Merge pull request #805 from glogiotatidis/969098

[fix bug 969098] Mark announcement text safe.

Updated

5 years ago
Version: other → next

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
Version: next → 2014-02.2
You need to log in before you can comment on or make changes to this bug.