Sandbox fails to build for b2g on OS X

RESOLVED FIXED in mozilla30

Status

()

Core
Security
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla30
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8371876 [details] [diff] [review]
Potential fix

Seeing build errors attempting to build B2G on my OS X machine. Narrowed down to a #include of nsExceptionHandler in Sandbox.cpp. This breaks because MOZ_CRASHREPORTER is not defined for this target. The fix appears to be to ifdef out that code.
Looks good, and the seccomp crash reporter integration still works on a linux-hosted build.  Can you upload the patch in Hg format (or git-format-patch format)?
Flags: needinfo?(erahm)
Created attachment 8371917 [details] [diff] [review]
fix_b2g_build.diff

Patched generated with git format-patch, let me know if this is the wrong format.
Attachment #8371876 - Attachment is obsolete: true
Flags: needinfo?(erahm)
normally it should have 8 lines of context diff, the git options in gitconfig are something like that:
[diff]
        git = 1
        unified = 8

or git format-patch -U8
Comment on attachment 8371917 [details] [diff] [review]
fix_b2g_build.diff

Carrying over r=kang from previous version.
Attachment #8371917 - Flags: review+
fixed on central https://hg.mozilla.org/mozilla-central/rev/eb8002584068

jld i guess the commit message has the wrong bugnumber which caused some confusion in bug 969126, could you make sure in the future to include the correct bugnumber (otherwise our merge tools gets confused) thanks :)
That was me, sorry for the confusion!
Assignee: nobody → erahm
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.