96916 - Support easy way to add a few bookmarks via CCK

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, enhancement, P1)

Description

[bobj]

Request has been made for the ability to add a CCK UI which allows the
addition of a few (~5) bookmarks in a single section near the top of the
default bookmarks.  

The UI would not allow modifying or removing existing bookmark defaults.

We might want to add and HTML comment to the default bookmarks to be used as
a token that can be easily parsed and replaced with the new additional bookmark
section.

Comment 1

[Barrett Lindstrom]

Updating QA contact to jimmyu for half of the CCK bugs, while Bom-shik is gone.

Comment 2

[Shruti Vasudevan]

Attachment: Bookmark customization proposal

Comment 3

[Shruti Vasudevan]

Adding nsbeta1 keyword. According to bug triage, it was considered nice to have
for beta if time permits. Since I was'nt sure what keyword to add at that point
of time, adding now.

Comment 4

[Rob Jaworski]

in for rtm per triage.

Comment 5

[Rob Jaworski]

cckrtm+

Comment 6

[Shruti Vasudevan]

Attachment: Patch to support easy way to add bookmarks

The patch includes a new screen for custom bookmarks namely bookmarks.ini. The
custom personal toolbar items have been adjusted in an existing CCK screen
(customize_page1.ini) instead of having a separate screen. Major part of the
implementation details go into ib.cpp, the new function ModifyBookmarks
includes the steps for adding both custom bookmarks and personal toolbar. The
old way of customizing bookmarks has been eliminated, hence all the deletions
in .che files.

Comment 7

[Shruti Vasudevan]

Attachment: Screen shot of toolbar screen

Comment 8

[Shruti Vasudevan]

Attachment: Screen shot of bookmarks screen

Comment 9

[Steve Meredith (gone)]

+
ifstream srcf(inputFile);
+
if (!srcf)
+
{
+
	AfxMessageBox("Cannot open input file: " + CString(inputFile),MB_OK);
+
	return;
+
}       
+
ofstream dstf(outputFile); 
+
if (!dstf)
+
{
+
	AfxMessageBox("Cannot open output file: " + CString(outputFile), MB_OK);
+
	return;
+
}

Close srcf if dstf fails to open.

Otherwise, r=smeredith

Comment 10

[Shruti Vasudevan]

Attachment: Updated ib.cpp file

Comment 11

[Shruti Vasudevan]

Marking fixed.

Comment 12

[Shruti Vasudevan]

Marking fixed.

Comment 13

[blee]

Verified fixed in 6/24 bld.