Closed Bug 969265 Opened 6 years ago Closed 6 years ago

[Settings][meta] marionette tests and panel refactor for 1.4

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [ucid:SystemPlatform30, 1.4, ft:system-platform])

marionette tests coverage and panel refactor for 1.4
Depends on: 956210
Depends on: 964180, 969264
Summary: [Settings][meta] marionette tests coverage and panel refactor for 1.4 → [Settings][meta] marionette tests and panel refactor for 1.4
No longer depends on: 969264
Depends on: 968681, 968682, 968686, 968692
Depends on: 957100
Depends on: 968679
Depends on: 956642
Blocks: 956210
No longer depends on: 956210, 956642, 964180
include refactor for
- do not track panel
- help panel
Depends on: 964188
ivan you can track Setting panel isolation tasks here
Flags: needinfo?(itsay)
Flags: needinfo?(itsay)
Whiteboard: [ft:system-platform]
Depends on: 959053
Depends on: 971623
Depends on: 971624
Depends on: 971625
No longer depends on: 971623, 971624, 971625
Depends on: 972160
Make sure your tests are passed at least 30 times continually on Travis before you set r?.

You could do cherry-pick this patch https://github.com/evanxd/gaia/commit/2bd7bb516b109e1ac19ec0957888841c12ee94e3 to run your tests(not included other tests).

Please don't run all tests in Gaia project for 30 times at one pull request.
It take time and resource too much.

If the patch in Bug 972160 is landed, it will run your tests in a pull request for 30 times automatically instead of using the 2bd7bb516b109e1ac19ec0957888841c12ee94e3 patch.

Thanks.
Comment 3 is the tip of sending review request for marionette test patch.
* Review process for marionette test:

Make sure your tests are passed at least 30 times continually on Travis before you set r?. Then leave the URL of 30 times pass Travis page on the review request message on bugzilla page.

* How to run test for 30 times:

You could do cherry-pick this patch https://github.com/evanxd/gaia/commit/2bd7bb516b109e1ac19ec0957888841c12ee94e3 to run your tests(not included other tests).
You could config your test files in `tests/travis_ci/marionette_js_multi/script
` file.

* Notice:
Please don't run all tests in Gaia project for 30 times at one pull request.
It take time and resource too much.

If the patch in Bug 972160 is landed, it will run your tests in a pull request for 30 times automatically instead of using the 2bd7bb516b109e1ac19ec0957888841c12ee94e3 patch.

Thanks.
Hi all, the patch for Bug Bug 972160 is landed.

New rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), before you set r? for your patch.

Thanks.
Use this one for the settings app refactoring meta bug for tracking. In v1.4, the scope is to finish the unittest cases before getting into the refactoring. The plan is to ensure the quality on settings app refactoring.
Whiteboard: [ft:system-platform] → [ucid:SystemPlatform30, 1.4, ft:system-platform]
Target Milestone: --- → 1.4 S2 (28feb)
Assign this user story/meta bug to Fred Lin for tracking on any engineering bug update/dependency.
Assignee: nobody → gasolin
No longer depends on: 968686
marionette tests done and we'll focus on refactor panels
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.