969291 - Record who marked a question as solved

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[Kadir Topal [:atopal]]

Currently we record only that a question was marked as solved, but since moderators are marking things as solved too, it's unclear whether a question was marked as solved by a moderator or the user.

We don't have to make that visible on the page, but we need a way to tell who solved a thread when querying the database for metrics.

Specifically, I'd like to know what our solution rate is considering only users marking things as solved. Changes we make to any of the flows try to improve that rate for users, not for moderators, so being able to tell them apart will give us a noise free indicator of success

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Specifically I'd love to see this but who would be able to see who marked the solution? Contributors? Moderators? Everybody?

Comment 2

[Kadir Topal [:atopal]]

I only wanted to have that in the db, but yeah, we could add a tool tip to the "chosen solution" text with the username of the person who chose it, like "Chosen as the solution by Jack"

Comment 3

[madalina]

+1 to Kadir's idea

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

The quick way to do this is to throw a new row in the questions_questionmetadata table.

The harder way (and better?) to do this is to add a new column to the table.

If we just need to display the solver on the question details page and use it for reporting, then we don't really need it to be a new column. If we want to show the solver on the question listing page, then it should be a column to avoid that extra join there (this wasn't requested in the bug).

My vote is to throw it into the question metadata table for now and we can always add the column later and migrate the data. For that, I am guessing 1pt

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1830

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/727bf97087bb07683803e553bdd4812e1bcb3ef1

Comment 7

[Michael Cooper [:mythmon]]

I pushed this to prod just now.

Comment 8

[Kadir Topal [:atopal]]

Thanks!