969293 - [FTE] In FTE, when PIN is inserted, I can't see "Cellular data" screen instead i see "Select a network" screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Loli (:lolimartinezcr)]

Tested (02/07)
1.3
Gecko 612a51c
Gaia 3fc26ae

Pre-requisites:
SIM with PIN

Steps:
1. Begin FTE, press "Next" in first screen.
2. Insert PIN required and press "Next".

Actual result:
I see WIFI screen

Expected result:
I should see "Cellular data" screen.

Comment 1

[isabelrios]

More info:
When tapping on Back on Wifi networks screen, then the Cellular and Data Screen is shown, otherwise that screen is not shown during the FTE.

Comment 2

[Matthew Vaughan]

This issue started reproducing on the first b2g28 branch (1.3) build from 02/03/14. When testing this on the last aurora branch build from the same day, this issue does not reproduce.

- 1.3 aurora build (works) -
Device: Buri v1.3 MOZ RIL
BuildID: 20140203004001
Gaia: f9a37c77efb4621a1f57e4695b497d18601fe134
Gecko: 3d9d920ca43b
Version: 28.0a2
Firmware Version: V1.2-device.cfg

- 1.3 b2g28 build (broken) -
Device: Buri v1.3 MOZ RIL
BuildID: 20140203181708
Gaia: bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko: 9731b0b7fa78
Version: 28.0
Firmware Version: V1.2-device.cfg

Comment 3

[bhavana bajaj [:bajaj]]

(In reply to Loli from comment #0)
> Tested (02/07)
> 1.3
> Gecko 612a51c
> Gaia 3fc26ae
> 
> Pre-requisites:
> SIM with PIN
> 
> Steps:
> 1. Begin FTE, press "Next" in first screen.
> 2. Insert PIN required and press "Next".
> 
> Actual result:
> I see WIFI screen
> 
> Expected result:
> I should see "Cellular data" screen.

Does the cellular data screen ever appear in the FTE ? Or are we totally missing it ?

Comment 4

[Noemí Freire (:noemi)]

(In reply to bhavana bajaj [:bajaj] from comment #3)
> (In reply to Loli from comment #0)
> > Tested (02/07)
> > 1.3
> > Gecko 612a51c
> > Gaia 3fc26ae
> > 
> > Pre-requisites:
> > SIM with PIN
> > 
> > Steps:
> > 1. Begin FTE, press "Next" in first screen.
> > 2. Insert PIN required and press "Next".
> > 
> > Actual result:
> > I see WIFI screen
> > 
> > Expected result:
> > I should see "Cellular data" screen.
> 
> Does the cellular data screen ever appear in the FTE ? Or are we totally
> missing it ?

Hi,

Currently cellular data screen is totally missing, it doesn't appear except of in the case described in https://bugzilla.mozilla.org/show_bug.cgi?id=969293#c1 but it is not the straightforward path expected.

Comment 5

[Noemí Freire (:noemi)]

Francisco, could you please have a look at this bug?. Many Thanks!

Comment 6

[Preeti Raghunath(:Preeti)]

1.3+

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Thanks folk, will assign to my self and take a look!

F.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

It's working for me in master, will check in 1.3

Thanks!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, misread the bug, it's happening for me in master as well :(

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 16372

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8377206 [details] [review]
Pointer to PR 16372

Ugh, was worried that not having time to get unit tests into this before the 1.3 drop would come back to bite me. :/

r+'ing, but it looks like your unit test is failing travis due to missing handleCardState, so that'll need to be fixed first.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

\o/ thanks Kyle,

just modified unit tests, now green, waiting for the tree to be opened again!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master!

https://github.com/mozilla-b2g/gaia/commit/bcb5d69cb805b9bde8643dc30f87848b6fda5298

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8377206 [details] [review]
Pointer to PR 16372

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
We need this bug to let the user configure the 3g services on FTU
[Bug caused by] (feature/regressing bug #):
 Bug 958060
[User impact] if declined:
Huge, unable to configure data services on FTU
[Testing completed]:
Yes
[Risk to taking this patch] (and alternatives if risky):
Not really high, we are just modifying a use case for SIM
[String changes made]:

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Asking for qawatend to check for the patch

Comment 16

[bhavana bajaj [:bajaj]]

(In reply to Francisco Jordano [:arcturus] from comment #15)
> Asking for qawatend to check for the patch

I think you meant to get QA verification here..so switching qawanted->verifyme :)

Comment 17

[Salem Elkabule]

This issue is fixed on buri v 1.4 Mozilla RIL

Environmental Variables
Device: Buri 1.4 MOZ RIL
Build ID: 20140224040201
Gecko: https://hg.mozilla.org/mozilla-central/rev/31113754db3b
Gaia: ffb527b84594396ed611edf0a8a5a130d60a742f
Platform Version: 30.0a1
Firmware Version: V1.2-device.cfg

The "Cellular data" Page displays correctly after inserting the SIM PIN.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted bcb5d69cb805b9bde8643dc30f87848b6fda5298 to:
v1.3: 45bf5b9a913f2c0b369f0138a15eb374a13b3c10

Comment 19

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 1.4
Gecko 7312341
Gaia b5d0f9b

Hamachi 1.3
Gecko cccc26f7
Gaia 6194def