969305 - [LTE]According to protocol and roaming protocol of APN settings to make a data call.

Status: RESOLVED DUPLICATE of bug 978709

(Firefox OS Graveyard :: RIL, defect)

Description

[Ken Chang[:kenkai]]

When phone try to make a data call in LTE network, phone should know the values of the following 3 items, bearer data, protocol, and roaming protocol.

Comment 1

[Ken Chang[:kenkai]]

It is a 1.4+ bug.

Comment 2

[Ken Chang[:kenkai]]

Jessica, you should consider this when you implement new apn types. Assign this bug to you. Thanks.

Comment 3

[Jessica Jong [:jessica] (inactive)]

There should be no problem with protocol and roaming protocol.
Regarding to bearer data, from my understanding, it is used to match the radio technology; that is, apn is selected only if its bearer data matches the current radio technology. However, the selection of apn is done in gaia side for now. So, not sure how gecko is going to handle bearer data or no need to handle at all?

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

remove 1.4 flag as this is a feature work. let's use metabug (b2g-LTE-1.4) to keep tracking.

Comment 5

[Ken Chang[:kenkai]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #3)
> There should be no problem with protocol and roaming protocol.
> Regarding to bearer data, from my understanding, it is used to match the
> radio technology; that is, apn is selected only if its bearer data matches
> the current radio technology. However, the selection of apn is done in gaia
> side for now. So, not sure how gecko is going to handle bearer data or no
> need to handle at all?
You are right, we don't need to do it. Here is the feedback from partner.
https://bugzilla.mozilla.org/show_bug.cgi?id=951764#c17

Comment 6

[Ken Chang[:kenkai]]

According to comment 5, removing bearer from summary. And this bug isn't a blocker.

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

I'd like to understand comment #5 as I'll take care of the changes needed in the APN selection logic in the setting app. First of all as bearer data is a property of the APN it will be passed to the RIL plumbing. It's up to the RIL plumbing to use it or not. Second; I need to understand this:

> > Regarding to bearer data, from my understanding, it is used to match the
> > radio technology; that is, apn is selected only if its bearer data matches
> > the current radio technology.

Does the above means that the APN list to be shown in the setting app depends on the radio technology underneath?

Comment 8

[Jessica Jong [:jessica] (inactive)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #7)
> I'd like to understand comment #5 as I'll take care of the changes needed in
> the APN selection logic in the setting app. First of all as bearer data is a
> property of the APN it will be passed to the RIL plumbing. It's up to the
> RIL plumbing to use it or not. Second; I need to understand this:

Okay, I understand.

> 
> > > Regarding to bearer data, from my understanding, it is used to match the
> > > radio technology; that is, apn is selected only if its bearer data matches
> > > the current radio technology.
> 
> Does the above means that the APN list to be shown in the setting app
> depends on the radio technology underneath?

Yes, if there is a bearer data on in the apn setting, it is selected only if it matches the current radio technology, but I am not sure if it needs to be hidden in the UI if not matched. And from bug 951764 comment 17, it seems that we also need to consider radio technology change, e.g. from LTE to CDMA.
You can use mozMobileConnections[x].data.type to check the current radio technology and refer to Android's design in [1] from line 2009.

Thank you!

[1] https://android.googlesource.com/platform/frameworks/opt/telephony/+/master/src/java/com/android/internal/telephony/dataconnection/DcTracker.java

Comment 9

[Jessica Jong [:jessica] (inactive)]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #8)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #7)
> > I'd like to understand comment #5 as I'll take care of the changes needed in
> > the APN selection logic in the setting app. First of all as bearer data is a
> > property of the APN it will be passed to the RIL plumbing. It's up to the
> > RIL plumbing to use it or not. Second; I need to understand this:
> 
> Okay, I understand.
> 
> > 
> > > > Regarding to bearer data, from my understanding, it is used to match the
> > > > radio technology; that is, apn is selected only if its bearer data matches
> > > > the current radio technology.
> > 
> > Does the above means that the APN list to be shown in the setting app
> > depends on the radio technology underneath?
> 
> Yes, if there is a bearer data on in the apn setting, it is selected only if
> it matches the current radio technology, but I am not sure if it needs to be
> hidden in the UI if not matched. And from bug 951764 comment 17, it seems
> that we also need to consider radio technology change, e.g. from LTE to CDMA.
> You can use mozMobileConnections[x].data.type to check the current radio
> technology and refer to Android's design in [1] from line 2009.
> 
> Thank you!
> 
> [1]
> https://android.googlesource.com/platform/frameworks/opt/telephony/+/master/
> src/java/com/android/internal/telephony/dataconnection/DcTracker.java

Oh, and here is to match radio technology string to the integer in the apn database (use the array index):
http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_consts.js#2604

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #8)
> > Does the above means that the APN list to be shown in the setting app
> > depends on the radio technology underneath?
> 
> Yes, if there is a bearer data on in the apn setting, it is selected only if
> it matches the current radio technology, but I am not sure if it needs to be
> hidden in the UI if not matched. And from bug 951764 comment 17, it seems
> that we also need to consider radio technology change, e.g. from LTE to CDMA.

Thanks for the information. So It seems the APN list depends not only on current radio technology but also on radio technology changes.

Comment 11

[Jessica Jong [:jessica] (inactive)]

Note that this is being handled in Bug 957917 attachment 8379454 [details] [diff] [review].

Comment 12

[Jessica Jong [:jessica] (inactive)]

All patches are integrated in bug 978709.