Closed
Bug 969324
Opened 12 years ago
Closed 12 years ago
ReporterEnumerator is badly designed and unnecessary
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
6.48 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
ReporterEnumerator is a wrapper for an nsCOMArray that is used to enumerate it. However we already have an enumerator for an nsCOMArray in the tree.
Having discovered that there is only one consumer of the enumerator, I realised that it was possible to cut out the middle man entirely.
I also changed the reporters tables to be typesafe (the current code was relying on a deprecated implicit cast in nsCOMPtr.h).
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8372206 [details] [diff] [review]
Proposed patch
Review of attachment 8372206 [details] [diff] [review]:
-----------------------------------------------------------------
Cool.
Attachment #8372206 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•