Closed
Bug 969330
Opened 10 years ago
Closed 10 years ago
Fix -Werror=int-to-pointer-cast in windows-only code.
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
4.29 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Those were not discovered by tbpl, because MSVC doesn't support the error. I found them in mingw build.
Attachment #8372213 -
Flags: review?(bjacob)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8372213 [details] [diff] [review] fix Review of attachment 8372213 [details] [diff] [review]: ----------------------------------------------------------------- I am not an authorized reviewer for these modules. If you want one person who would be a legit reviewer for this kind of patch touching these 3 files, I suppose that :bsmedberg or :ehsan would be it.
Attachment #8372213 -
Flags: review?(bjacob)
|
Assignee | |
Updated•10 years ago
|
Attachment #8372213 -
Flags: review?(ehsan)
|
||
Updated•10 years ago
|
Attachment #8372213 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks for reviews: https://hg.mozilla.org/integration/mozilla-inbound/rev/922bc2245f06
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/922bc2245f06
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•