969448 - Netmonitor selected filter reset to "All" upon every new page request.

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Dane MacMillan [:danemacmillan]]

The network monitor has filters at the bottom:

All | HTML | CSS | JS | XHR | Fonts | Images | Media | Flash | Other

When a filter is selected, it will show only requests for that filter. If the page is refreshed with a filter selected, the filter is cleared and defaulted back to "All." The same occurs when navigating to another page. 

Filters should persist between requests and not default back to "All."

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Confirmed on 30.0a1 (2014-02-07).

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8373593 [details] [diff] [review]
v1

Review of attachment 8373593 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/test/browser_net_prefs-reload.js
@@ +36,5 @@
>          modifyFrontend: ($, aValue) => $("#details-pane").setAttribute("width", aValue)
>        },
>        networkDetailsHeight: {
>          newValue: ~~(Math.random() * 300 + 100),
> +        validateValue: ($) => ~~$("#details-pane").getAttribute("height"),

you and your clever tricks!

Comment 4

[Victor Porof [:vporof][:vp]]

Fixed a failing test, added some more assertions and landed: https://hg.mozilla.org/integration/fx-team/rev/9d6029b3b35e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d6029b3b35e

Comment 6

[Benjamin Kerensa [:bkerensa]]

Robert, Since this now fixed do you think it needs tracking from us? I personally don't see why it would.

Comment 7

[Rob Campbell [:rc] (:robcee)]

tracking from whom? It's in 30, so no.