Closed Bug 969475 Opened 7 years ago Closed 7 years ago

[Settings] [Sound] - Select Ring tone and Alert tone flow does not work in FxOS Simulator(Firefox Nightly)

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: pdahiya, Assigned: pdahiya)

References

Details

Attachments

(1 file)

Not able to select ringtone and alerttones in latest Firefox Nightly

FF Nightly version: 30.0a1 (02-06-2014)
Gaia rev: ea4a1f0d94a995486ed219f47132949071ecc172

Steps to reproduce:
1. ../firefox -profile ../gaia/profile-debug,  Open FxOS Simulator.
2. launch settings app
3. click on sound
4. Ringer section under Tones is not visible and click of Change under Alerts does not work

Expected: Ringer section should be visible and click of change under Alerts should open select Alert tones screen
Assignee: nobody → pdahiya
On debugging, nightly errors out at https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/utils.js#L229 with 

_hwSupportedTypes is undefined error in logs. 

This works on devices where mobileConneciton.supportedNetworkTypes always have a supported network type. 

Returning from getSupportedNetworkInfo if _hwSupportedTypes is undefined resolve this bug in nightly. 

I will attach the patch with the fix.
Blocks: 968937
Hi George

Please review the patch with fix of showing ringer and opening select alert tone screen in FF Nightly.

Thanks!
Attachment #8372469 - Flags: review?(gduan)
Comment on attachment 8372469 [details] [review]
PR with fix of ringtone and alert tone flow in FF Nightly

Thanks for your fix. r=gduan
Attachment #8372469 - Flags: review?(gduan) → review+
Thanks George for the review. Fix landed on master 

https://github.com/mozilla-b2g/gaia/commit/d365bd3b78cc901a3a1c05397e22a7833f744465
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.