969558 - Get rid of "choose all" in Merge Groups interface

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: get rid of "choose all"

There is no instance when we would want to merge all Mozillians.org groups into one. Doing so by mistake would either succeed, which would be unfortunate, or would fail, leaving data in an uncertain state.

Having that as an option in /admin presents an unnecessary risk to group data. We should get rid of that option. See attached screenshot.

Comment 1

[Jeff Potts]

I've got this fixed on my local machine. Just want to clean up a couple of things then I'll create the pull request. Can someone assign this to me?

Comment 2

[Jeff Potts]

Committed and created pull request: https://github.com/mozilla/mozillians/pull/802

Comment 3

[William Reynolds [:williamr]]

Thanks for working on this bug, Jeff! Your pull request will be reviewed soon.

Comment 4

[Jeff Potts]

I have closed my original pull request and submitted a new one based on the helpful feedback from Giorgos. The new pull request is: https://github.com/mozilla/mozillians/pull/812

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/713b06f7f5217bdcfa955dbd1287919f8aacaec2
[fix bug 969558] Remove 'Choose All' link from Group Merging Widget.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Verified working on stage. Thanks Jeff for fixing!