unify getters and setters for event handlers in bindings code

NEW
Unassigned

Status

()

P5
normal
5 years ago
2 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Noticed this while working on the jsid stuff: the getters and setters for event handlers are virtually identical; we should have some common code for these.  It looks like ones that throw (?) might have to be treated separately.

The getters and setters combined take up ~150K on ARM, or about as much as win as bug 956806 had.

Really, this sort of thing could potentially be extended to all types, but event handlers seemed more straightforward...and there might be more noticeable performance impacts for something like primitive types?  Something to consider, anyway.
Identical except for calling a different underlying C++ method, right?

This would require a lot more special-casing than bug 956806 did.  :(
(Reporter)

Comment 2

5 years ago
(In reply to Boris Zbarsky [:bz] from comment #1)
> Identical except for calling a different underlying C++ method, right?

Indeed.

> This would require a lot more special-casing than bug 956806 did.  :(

Also true. :(  I don't have any good ideas here.
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.