969580 - Cached images should be discarded when our Direct2D device dies

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Bas Schouten (:bas.schouten)]

When our Direct2D device dies we may still have VectorImages in the SurfaceCache that contain Drawables holding on to D2D drawtargets belonging to the old D2D device. In the future other images may also have drawables which hold on only to now invalid GPU memory. We should simply discard the entire surface cache in the event of a device malfunction.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Expose DiscardAll from the SurfaceCache public interface.

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Discard the entire SurfaceCache when Direct2D fails.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8372516 [details] [diff] [review]
Part 2: Discard the entire SurfaceCache when Direct2D fails.

Review of attachment 8372516 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a good fix for this specific problem.

It seems like, in the long term, we are going to start accumulating more cases where we need to do this. Maybe in the future it'd make sense to make this an event that various subsystems could listen for.

Comment 4

[Bas Schouten (:bas.schouten)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba45c5c19ce8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d08cf861ff7a

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ba45c5c19ce8
https://hg.mozilla.org/mozilla-central/rev/d08cf861ff7a