969656 - "Sign in again" menu panel UI should link directly to the sign-in page, rather than preferences

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

The "reconnect to sync" error state in the menu panel should go directly to the sign in page, rather than opening Sync preferences, matching what happens if you click "Sign in" on the doorhanger.

In practice I think this means browser-fxaccounts' onMenuPanelCommand needs to handle three cases:
- sync not set up: this.openAccountsPage();
- sync signed in: this.openPreferences();
- sync set up but auth failed: this.openSignInAgainPage()

(It currently only handles the first two.)

this.loginFailed should probably be used to distinguish between the second two cases.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-969656-Sign-in-again-menu-panel-UI-should-link-d.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/a73a740fa69f

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a73a740fa69f

Comment 4

[Tracy Walker [:tracy]]

Gavin, How do you get into the "reconnect to sync" error state in the menu panel?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

You can reach this state by signing into FxA on on browser and then changing the password for the same account on another profile. The original profile should then tell you to reconnect on next startup.

Comment 6

[Tracy Walker [:tracy]]

Tim, thank you.

Verified with latest Nightly builds.  reconnect to sync account Sign-in button goes directly to sign-in page.

Comment 7

[Tracy Walker [:tracy]]

Should this be uplifted to Aurora?

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Yup, just wanted to wait until it's verified.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8374053 [details] [diff] [review]
0001-Bug-969656-Sign-in-again-menu-panel-UI-should-link-d.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: Users would be sent to the prefs dialog instead of the sign-in page when clicking the error message that says "sign in again".
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): No risk.
String or IDL/UUID changes made by this patch: None.

Comment 10

[Tracy Walker [:tracy]]

Is it safe to assume all these Sync UI fixes from 2 week sprints should be uplifted?

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #10)
> Is it safe to assume all these Sync UI fixes from 2 week sprints should be
> uplifted?

Yeah, most or all of the sync bugs we're currently working on are higher priority and we will want them in 29 as well. Thanks for keeping an eye on this!

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6639d3d3701c