969667 - merge mobile and desktop feedback forms

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

This bug covers merging the mobile and desktop feedback forms into one single form that uses responsive design and reuses strings from one or the other form.

Two caveats:

1. we shouldn't create any new strings
2. we should account for privacy-related comments in those privacy bugs

This will probably let us get rid of some of the goofy form routing we have, too.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Adding whiteboard data and making this block the tracker.

I think this is two points. I suspect we should just take the mobile form and flesh it out with what's missing from the desktop form. That seems like a 2-point task.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Matt: Do you mind terribly if I take a day next week to slam-dunk this? It'll make life easier because then we'll only have two feedback forms rather than three and it'll give me a chance to fix the desktop/mobile one in regards to privacy information text.

This makes some future work easier like adding drop-off measuring, etc.

Comment 3

[Matt Grimes [:Matt_G]]

Sounds good to me! Let's do it.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing it to try to do it this week.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This should block the drop-off work since it'll make it easier to do.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/221

Here are some screenshots from Firefox on my laptop:

First page: http://bluesock.org/~willkg/images/link/1393288686.png
Second page: http://bluesock.org/~willkg/images/link/1393288745.png
Third (final) page: http://bluesock.org/~willkg/images/link/1393288779.png

I tried to fix a lot of the privacy informational text so that it showed up before the relevant fields, was succinct and made it very clear what was and wasn't going to be public. Part of this work was to move the email-related stuff to a separate card so one card as stuff that will be shown public and one card is all private information.

I totally redid all the code so that it's more like the Firefox OS form we have (easier to maintain two like things) and also is much easier to add additional cards, measure drop-off rates, test, etc.

I tried to streamline the text so what we had was clearer and flowed better. I tried to do that with the difficult restriction of only reusing strings--there are no new strings on this form. Because there are no new strings, we can land it and push it out right now rather than have to way for l10n work to be done.

I tried to make it clean looking, but didn't spend a lot of time making it really pretty. Slater mentioned that we should do a Sandstone theme overhaul on the site. I agree. I figure that Sandstone overhaul can additionally prettify these forms. If there are small changes we want to make now, I can probably do them, but we'll have to prioritize them against everything else we want to do (obviously).

Generally, this overhaul consists of a lot of compromises to get us to a muccchhh better place where we can do things we need to do in the near term.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This ended up being about 3 points of work. Tagging it accordingly.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Matt: Can you look at the screenshots in comment #6? Do these changes look ok? Does the text flow ok? Compare them with the current desktop and mobile forms:

https://input.mozilla.org/feedback/firefox.desktop.stable/
https://input.mozilla.org/feedback/firefox.android.stable/

If these look ok, then I'll replace the existing desktop and mobile forms with this one.

If you're on the fence, I can push these out *without* affecting the current forms and we can play with it live in production without affecting anyone else.

Having said that, I want to land this soon since it's blocking the work to measure drop-off rates and I need to move on to other things.

Comment 9

[Matt Grimes [:Matt_G]]

This looks rock solid to me! Unless you see some reason to wait, I say we push it move forward.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in:

https://github.com/mozilla/fjord/commit/e708164
https://github.com/mozilla/fjord/commit/600f02c
https://github.com/mozilla/fjord/commit/cfc3814

I'll push it to prod tomorrow morning when I can watch the server numbers for problems.

After I push it out, I'll send an email about it.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to prod!

One not-very-good thing about this is that the desktop form is now gray and prison-like and that's unfortunate. However, this fixed a ton of stuff and unblocks a bunch of work, so that's good.

I'll keep an eye on Input numbers to make sure I didn't goof somewhere.

Marking as FIXED now.

Comment 12

[Matt Grimes [:Matt_G]]

Awesome stuff! Thanks again.