969699 - Branding variable "brandShortName" not correctly replaced for non en-US locales accross the OS

Status: RESOLVED DUPLICATE of bug 996479

(Firefox OS Graveyard :: Gaia, defect)

Description

[u497809]

Attachment: Screen Shot 2014-02-07 at 7.26.00 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140201074923

Steps to reproduce:

I built a gaia debug profile with the following command:
DEBUG=1 make

And ran gaia with the latest firefox nightly build.

With the firefox OS emulator, I scroll to the second page and click on the Settings application.


Actual results:

The second to last option on the page says "Improve {{brandShortName}}"


Expected results:

The selection label should have the template value filled in as "Improve B2G OS" if using the unofficial locale branding and "Improve Firefox OS" if using the official locale branding.

Comment 1

[u497809]

The reason this bug occurs it seems is that under /shared/locales/branding the branding files are now split between "unofficial" and "official"

If possible I would like to claim this bug.

I think by checking the PRODUCTION variable in the makefile we can choose the correct one and render the template correctly.

Comment 2

[Théo Chevalier]

Just noticed the bug was opened way before master was affected, but this is currently affecting master builds on Flame since a few days. Maybe dupe of another bug. Flod, you opened something?

Comment 5

[Francesco Lodolo [:flod]]

The branding issue was fixed in bug 996479, the only pending problem was that we were still failing if we set a default locale different from en-US (we don't fall back), and that's bug 1030035.

The issue came back in the last couple of days. For clarity I'm closing this as dupe of bug 996479, and keeping one of the other two open.