Closed Bug 969700 Opened 7 years ago Closed 7 years ago

Listen only for top-level DOMTitleChanged in SessionStore.js

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox28 fixed, firefox29 fixed, firefox30 fixed)

RESOLVED FIXED
Firefox 30
Tracking Status
firefox28 --- fixed
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

No description provided.
Follow-up to the last-minute changes made in bug 965137 before landing. Rather than a catch-all listener that needs to use getBrowserForDocument() to get the browser, we can attach a DOMTitleChanged listener to each newly-added tab's browser like we did with pageshow. Also, more importantly, we should do a top-level check to make sure we aren't calling onTabLoad for iframes.
Attachment #8372675 - Flags: review?(mark.finkle)
Comment on attachment 8372675 [details] [diff] [review]
Listen only for top-level DOMTitleChanged in SessionStore.js

>diff --git a/mobile/android/components/SessionStore.js b/mobile/android/components/SessionStore.js

>   onTabRemove: function ss_onTabRemove(aWindow, aBrowser, aNoNotification) {
>+    aBrowser.removeEventListener("DOMTitleChanged", this, true);
>     // If this browser is being restored, skip any session save activity

add a blank line before the comment
Attachment #8372675 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/728e3dd430c3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Uplifted with bug 965137.
See Also: → 1269189
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.