969700 - Listen only for top-level DOMTitleChanged in SessionStore.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Listen only for top-level DOMTitleChanged in SessionStore.js

Follow-up to the last-minute changes made in bug 965137 before landing. Rather than a catch-all listener that needs to use getBrowserForDocument() to get the browser, we can attach a DOMTitleChanged listener to each newly-added tab's browser like we did with pageshow. Also, more importantly, we should do a top-level check to make sure we aren't calling onTabLoad for iframes.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8372675 [details] [diff] [review]
Listen only for top-level DOMTitleChanged in SessionStore.js

>diff --git a/mobile/android/components/SessionStore.js b/mobile/android/components/SessionStore.js

>   onTabRemove: function ss_onTabRemove(aWindow, aBrowser, aNoNotification) {
>+    aBrowser.removeEventListener("DOMTitleChanged", this, true);
>     // If this browser is being restored, skip any session save activity

add a blank line before the comment

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/728e3dd430c3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/728e3dd430c3

Comment 5

[Brian Nicholson (:bnicholson)]

Uplifted with bug 965137.