969727 - Figure out why the [Func] check for MozInputMethod does not work as expected

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

See <http://mxr.mozilla.org/mozilla-central/source/dom/webidl/InputMethod.webidl#7> where we do:

7 [JSImplementation="@mozilla.org/b2g-inputmethod;1",
8  NavigatorProperty="mozInputMethod",
9  Func="Navigator::HasInputMethodSupport"]
10 interface MozInputMethod : EventTarget {
...

And <http://mxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#1911>:

1909 /* static */
1910 bool
1911 Navigator::HasInputMethodSupport(JSContext* /* unused */,
1912                                  JSObject* aGlobal)
1913 {
1914   nsCOMPtr<nsPIDOMWindow> win = GetWindowFromGlobal(aGlobal);
1915   if (Preferences::GetBool("dom.mozInputMethod.testing", false)) {
1916     return true;
1917   }
1918 
1919   return Preferences::GetBool("dom.mozInputMethod.enabled", false) &&
1920          win && CheckPermission(win, "input");
1921 }

If I'm reading this code correctly, window.MozInputMethod and navigator.mozInputMethod should only be exposed where the pref is enabled and the input permission has been granted.  But if I toggle the pref on desktop, both of these properties are exposed.

What am I missing?

Comment 1

[Boris Zbarsky [:bzbarsky]]

> But if I toggle the pref on desktop, both of these properties are exposed.

In which build?  I can't seem to reproduce this if I toggle "dom.mozInputMethod.enabled" locally in an inbound build from earlier today...

Comment 2

[(no longer active)]

(In reply to Boris Zbarsky [:bz] from comment #1)
> > But if I toggle the pref on desktop, both of these properties are exposed.
> 
> In which build?  I can't seem to reproduce this if I toggle
> "dom.mozInputMethod.enabled" locally in an inbound build from earlier
> today...

Latest Nightly.  But I was testing that on about:newtab.  I just tested on the google.com and couldn't repro.  Do we have special permissions on about:newtab or something?

Comment 3

[Boris Zbarsky [:bzbarsky]]

about:newtab runs with the system principal, and nsPermissionManager::CommonTestPermission returns nsIPermissionManager::ALLOW_ACTION for anything with the system principal.

Comment 4

[(no longer active)]

I see, false alarm then.  Thanks, and sorry for wasting your time.