Closed Bug 969821 Opened 10 years ago Closed 10 years ago

Preferences button tooltip reads "preferences-button.tooltiptext"

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3][good first verify] [testday-20140523])

Attachments

(1 file)

Fix Preferences menu item tooltip
1.22 KB, patch
Gijs
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
In the new menu on Australis, when hovering the Preferences item, the tooltip reads "preferences-button.tooltiptext".
Blocks: 940116
status-firefox29: --- → affected
OS: All → Linux
I think this is what's broken.
Attachment #8372818 - Flags: review?(jaws)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8372818 [details] [diff] [review]
Fix Preferences menu item tooltip

Ugh. My mistake. Ship it.
Attachment #8372818 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/dfa16a5df3f7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Comment on attachment 8372818 [details] [diff] [review]
Fix Preferences menu item tooltip

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 940116
User impact if declined: Linux users' preferences buttons will have the wrong tooltip
Testing completed (on m-c, etc.): m-c, locally
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none
Attachment #8372818 - Flags: approval-mozilla-aurora?
(just making sure we track that this ships on Aurora as well)
Blocks: australis-cust
Whiteboard: [Australis:P3]
Attachment #8372818 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [Australis:P3] → [Australis:P3][good first verify]
Verified fixed using Windows 7 64 bit and Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0. Verified in latest Nightly as well, setting the STATUS to VERIFIED.
Status: RESOLVED → VERIFIED
Whiteboard: [Australis:P3][good first verify] → [Australis:P3][good first verify] [testday-20140523]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: