Closed Bug 969835 Opened 6 years ago Closed 6 years ago

Don't check for HelperApps on about: and chrome: URLs

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: mfinkle, Assigned: wesj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I think we can bail out early when looking for HelperApps on pageload for about: and chrome: URLs. I don't think we should allow HelperApps for those URL schemes and it might save us a little CPU cycles.
HelperApps is a lazy module getter, so with any luck this'll also avoid that code being loaded.
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → All
Blocks: 918892
Attached patch avoidHelperAppsSplinter Review
This is mostly a stolen check from ReaderMode.
Attachment #8374482 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8374482 [details] [diff] [review]
avoidHelperApps

Review of attachment 8374482 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.
Attachment #8374482 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ce6caf543408
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.