Closed Bug 969869 Opened 6 years ago Closed 6 years ago

Use fallible allocation in WebGL element array cache; r=bjacob

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

It seems like the sizes for these data structures can be controlled from
Web content, and we are already prepared to deal with OOM conditions,
except that we are using infallible allocations by mistake.
Assignee: nobody → ehsan
Blocks: 969864
Attachment #8372840 - Flags: review?(bjacob)
Comment on attachment 8372840 [details] [diff] [review]
Use fallible allocation in WebGL element array cache; r=bjacob

Review of attachment 8372840 [details] [diff] [review]:
-----------------------------------------------------------------

>It seems like the sizes for these data structures can be controlled from Web content,

Correct,

> and we are already prepared to deal with OOM conditions,

Apparently correct too, from a quick look at the code.
Attachment #8372840 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/1bab733c5a83
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.