969931 - PSM test certificate generation does not work on Windows using MozillaBuild

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

> import pexpect

pexpect isn't available on Windows.

Is there a way to modify these scripts to avoid pexpect?

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

> $ cd security/manager/ssl/test/unit/test_ev_certs/
> $ ./generate.py
> [snip]
> ImportError: no module names pexpect

Also not installed by default on Linux.

Comment 2

[:Cykesiopka]

Attachment: bug969931_rm-pexpect-PSM-cert-gen-scripts_v1.patch

This patch removes all uses of pexpect from the PSM cert generation scripts.

The scripts and resultant certs worked on my Linux install, but I don't have the NSS tools set up in MozillaBuild, so I don't know if the scripts now work properly on Windows.
  => I'm just going to leave this here for now.

If someone wants to test or finish the patch, please feel free.

Comment 3

[:Cykesiopka]

(In reply to Cykesiopka from comment #2)
> Created attachment 8530802 [details] [diff] [review]

FWIW, the strategy for the certutil cases is equivalent to what is currently done in test_certificate_usages/generate.pl.

Comment 4

[:Cykesiopka]

Now that PSM cert generation is done via pycert.py and friends (see Bug 1174288 and dependencies), this is no longer an issue.

I confirmed using stock MozillaBuild 2.2 that:
 - The only generate.py file works.
 - The mechanism to generate certs at build time (although disabled at the moment) works.