Closed Bug 969932 Opened 6 years ago Closed 6 years ago

enable sendfile(2) again in libevent on freebsd

Categories

(Core :: IPC, defect)

x86_64
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox27 --- unaffected
firefox28 --- verified
firefox29 --- verified
firefox30 --- verified
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch fixSplinter Review
Given that the typo didn't break NetBSD and OpenBSD I think it's safe to define the macro unconditionally. buffer.c already checks for platform before actually using sendfile(2).
Attachment #8372921 - Flags: review?(mh+mozilla)
Bug 883502 had wrong comment but correct code

  ifneq (,$(filter DragonFly FreeBSD,$(OS_ARCH))) # (not OS_DRAGONFLY and not OS_FREEBSD) {

and bug 874266 converted the comment into wrong code

  if not os_freebsd and not os_dragonfly:
Blocks: 874266
Attachment #8372921 - Flags: review?(mh+mozilla) → review+
Add a=NPOTB for aurora and beta.
Keywords: checkin-needed
Whiteboard: [checkin-needed-beta] [checkin-needed-aurora] [npotb]
https://hg.mozilla.org/mozilla-central/rev/c0a263e2a70b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Jan, please verify this is fixed for Firefox 28, 29 and 30. Thank you.
Flags: needinfo?(jbeich)
Whiteboard: [qa-]
The fix works as expected on all the branches I requested it. buffer.o (part of libevent) calls sendfile(2) defined somewhere else (in libc syscall wrapper).

$ objdump -t obj-*/ipc/chromium/buffer.o | fgrep sendfile
0000000000000000 l     O .bss   0000000000000001 use_sendfile
0000000000003ea0 g     F .text  0000000000000014 .hidden _evbuffer_testing_use_sendfile
0000000000000000         *UND*  0000000000000000 sendfile
You need to log in before you can comment on or make changes to this bug.