Closed
Bug 969932
Opened 10 years ago
Closed 10 years ago
enable sendfile(2) again in libevent on freebsd
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jbeich, Assigned: jbeich)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
1.66 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Given that the typo didn't break NetBSD and OpenBSD I think it's safe to define the macro unconditionally. buffer.c already checks for platform before actually using sendfile(2).
Attachment #8372921 -
Flags: review?(mh+mozilla)
Bug 883502 had wrong comment but correct code ifneq (,$(filter DragonFly FreeBSD,$(OS_ARCH))) # (not OS_DRAGONFLY and not OS_FREEBSD) { and bug 874266 converted the comment into wrong code if not os_freebsd and not os_dragonfly:
Blocks: 874266
status-firefox27:
--- → unaffected
status-firefox28:
--- → affected
status-firefox29:
--- → affected
status-firefox30:
--- → affected
Updated•10 years ago
|
Attachment #8372921 -
Flags: review?(mh+mozilla) → review+
Add a=NPOTB for aurora and beta.
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a263e2a70b
Assignee: nobody → jbeich
Keywords: checkin-needed
Whiteboard: [checkin-needed-beta] [checkin-needed-aurora] [npotb]
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c0a263e2a70b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Comment 5•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c5af36178cb9 https://hg.mozilla.org/releases/mozilla-beta/rev/88806ebdaacd
Whiteboard: [checkin-needed-beta] [checkin-needed-aurora] [npotb]
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
Jan, please verify this is fixed for Firefox 28, 29 and 30. Thank you.
Flags: needinfo?(jbeich)
Whiteboard: [qa-]
The fix works as expected on all the branches I requested it. buffer.o (part of libevent) calls sendfile(2) defined somewhere else (in libc syscall wrapper). $ objdump -t obj-*/ipc/chromium/buffer.o | fgrep sendfile 0000000000000000 l O .bss 0000000000000001 use_sendfile 0000000000003ea0 g F .text 0000000000000014 .hidden _evbuffer_testing_use_sendfile 0000000000000000 *UND* 0000000000000000 sendfile
Flags: needinfo?(jbeich)
Updated•10 years ago
|
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•