969937 - Don't generate and push robotium.config in talos

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks not generating and pushing robotium.config to devices in talos; instead, we should use additional command line arguments (adb am instrument -e ...).

Comment 1

[Nick Alexander :nalexander [he/him]]

gbrown, jmaher: y'all are better versed in the talos side of things.  Can you think of any reason why we can't do this?  Why we wouldn't want to do this?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this isn't really a talos specific issue more than a how can we realistically do this in a commandline.  If we can, then I am fine.

A couple of questions:
1) why do we need to do this?
2) is there a concern with a long commandline going to adb and possibly the browser?  we have had issues like this in the past

Comment 3

[Nick Alexander :nalexander [he/him]]

> A couple of questions:
> 1) why do we need to do this?
> 2) is there a concern with a long commandline going to adb and possibly the
> browser?  we have had issues like this in the past

Hey, thanks for the quick response.  I see I should have needinfo-ed you on Bug 969933, where I address both my motivation and your concern [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=969933#c0

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I commented in bug 969933.  There appears to be no issue doing this, but there is no real benefit.

Comment 5

[Geoff Brown [:gbrown]]

There is a limit (256 or 1024 characters?) to the adb command line; you will need to watch out for that. I also wonder if there might be some variation in "am instrument" implementations from one Android version to another.

I don't have a strong opinion, but robotium.config works for me: It hasn't caused me any problems, and it is flexible.

Comment 6

[Geoff Brown [:gbrown]]

Android Robocop-Talos is no longer a thing.