Closed Bug 969960 Opened 10 years ago Closed 10 years ago

Add youtube wrapper directly to smart

Categories

(Webmaker Graveyard :: popcorn.js, defect)

Product:
Webmaker Graveyard
Component:
popcorn.js
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

https://github.com/mozilla/popcorn-js/pull/380
46 bytes, text/x-github-pull-request
jon
: review+
mjschranz
: review+
Details | Review 
The smart player is still using the old youtube player, which then uses the wrapper.

We can skip this step by adding the youtube wrapper to the list here: https://github.com/mozilla/popcorn-js/blob/master/modules/player/popcorn.player.js#L352
Assignee: nobody → scott
Attachment #8373544 - Flags: review?(schranz.m)
Attachment #8373544 - Flags: review?(schranz.m) → review+
Attachment #8373544 - Flags: review?(jon) → review+
Staged: https://github.com/mozilla/popcorn-js/commit/7f647e882548926226fa78b6f0f82f65aab4973f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 973369
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: