969978 - [B2G][l10n][keyboard] it: Change order of accented letters (e, i) and alternate punctuation chars

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Iacopo Benesperi [:iacchi]]

FFOS 1.3 on a GP Keon.
I don't know if this bug belongs to l10n or to the keyboard component, but anyway: in the Italian keyboard the default set of alternate punctuation chars (the ones that pop up when you keep tapping on the full stop char) are: "…", "·", ":", ";", ","
I propose to change this sequence with this one: "!", "?", ":", ";", "," since the triple dots and the central dot are almost never used and surely we don't need them in the fast pop up.

Comment 2

[Francesco Lodolo [:flod]]

Unified from bug 969982

(In reply to Iacopo Benesperi [:iacchi] from comment #0)
> FFOS 1.3 on a GP Keon.
> I don't know if this bug belongs to l10n or to the keyboard component, but
> anyway: in the Italian keyboard, the pop-up with alternate chars that
> appears when you keep tapping on a key, related to the "e" and "i" keys, is
> this one: "é, è, ..." and "í, ì, ...".
> Since the acute accent (è, ì) is very much more used in Italian than the
> grave one, it would be best if the first char selected when you show the
> pop-up with alternate chars is the one with the acute accent instead of the
> one with the grave one. The sequence should then become "è, é, ..." and "ì,
> í, ...".

Comment 3

[Francesco Lodolo [:flod]]

Adding Luigi who did the original implementation, and moving to Firefox OS::Keyboard. 
Pull Request should be ready in a few minutes.

Comment 4

[Francesco Lodolo [:flod]]

Iacopo, I'm checking the current layout
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/it.js

Of all issues reported, only the one about "éè" is present.

For "i" we only have "ì" (I don't think "í" is actually used in Italian).

Alternate order for punctuation is ",;:·…", which seems pretty correct. I think you're looking at it in the wrong way: they go from right to left, since the "." button is located on the far right.

Can you check? Other thoughts on the current layout? When Luigi created it, I suggested to remove as many unnecessary alternate characters as possible. See English layout for reference
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/en.js

Comment 5

[Iacopo Benesperi [:iacchi]]

currently I'm using on my Keon a build dated 07/02/2014. If things are changed in these two last days then I may be wrong, but this is what I have now: I have two active keyboards, Number and Italiano.

You're right about ì, in fact the problem is only with éè (there's also òó, but they appear in the correct order, sorry, my bad).

Alternate order for punctuation is now ",;:·…" (I inverted it because I reported it as it was seen on screen), but IMO it should be ",;:?!" since we use ? and ! much more frequently than · and …

Other thoughts are that we may put also numbers in the top row, but if you want to keep things simple then I'd say that all the other keys look fine.

Comment 6

[Iacopo Benesperi [:iacchi]]

I may add, an even better order would be ",;:'?!", since we use the apostrophe quite a lot in Italian and right now you have to open the Number keyboard to enter it.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Iacopo Benesperi [:iacchi] from comment #5)
> Other thoughts are that we may put also numbers in the top row, but if you
> want to keep things simple then I'd say that all the other keys look fine.

I don't think people would expect numbers there, unless they add a visual "hint".

Comment 8

[Francesco Lodolo [:flod]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16106

Comment 9

[Francesco Lodolo [:flod]]

Attachment: updated_keyboard.png

Screenshot of updated keys

Comment 10

[Iacopo Benesperi [:iacchi]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> I don't think people would expect numbers there, unless they add a visual
> "hint".

True but, even without visual hints, once you find out, the usefulness of the thing will make you like it a lot. Anyway, as I said, if we want to keep things simple then the way it is now is pretty good.

Comment 11

[[e-mail]]

Francesco's patch is ok for me.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8372977 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16106

Looks pretty good to me as well.
Thanks for patching this up.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/7a317b04529263e19a837d407aeae558d7a71aff

Comment 14

[Francesco Lodolo [:flod]]

Thanks Rudy.

Setting 1.3? now that I'm sure the patch is fine: this is a low risk change, but it definitely improves the keyboard experience for Italian users.

Comment 15

[Francesco Lodolo [:flod]]

Verified flashing master on device (Keon, git commit 7ef49416).

Comment 16

[Iacopo Benesperi [:iacchi]]

Yes, having it on 1.3 would be great.

Comment 17

[Preeti Raghunath(:Preeti)]

Lets take this for 1.3, makes better user experience.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7a317b04529263e19a837d407aeae558d7a71aff to:
v1.3: 6cb86c92a2a73ebec600c4711dab188ffb33beb0