970112 - Geolocation no longer working in Nightly

Status: VERIFIED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Elad Alfassa]

GeoLocation simply stopped working in Nightly sometime in the last few days, navigator.geolocation.getCurrentPosition never calls the callbacks (no error either).

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Also not working on Win7 x64 m-c tinderbox build:
cset: https://hg.mozilla.org/mozilla-central/rev/7133bb431eba

Comment 2

[Elad Alfassa]

Attachment: Quick Testcase

Quick testcase: if it works you should see an alert box.

Comment 4

[Doug Turner (:dougt)]

works for me on 30.0a1 (2014-02-09) Mac.  I'll try windows tonight.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Testcase doesn't show an alert. Windows 8.1, current Nightly. I noticed Google maps also fails to locate me since a week or so?

Comment 7

[Justin Dolske [:Dolske]]

WFM on OS X, and fails on Windows. No messages in the browser/error consoles.

Comment 8

[Jim Mathies [:jimm]]

This is working for me on Windows 8.1 desktop in nightly from a checkout this morning, failing in aurora and beta.

Comment 9

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #8)
> This is working for me on Windows 8.1 desktop in nightly from a checkout
> this morning, failing in aurora and beta.

Correction - I get the doorhanger in my local build, but once I approve it I get an error for the actual lookup. I don't see the doorhanger in these other builds.

Comment 10

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #9)
> (In reply to Jim Mathies [:jimm] from comment #8)
> > This is working for me on Windows 8.1 desktop in nightly from a checkout
> > this morning, failing in aurora and beta.
> 
> Correction - I get the doorhanger in my local build, but once I approve it I
> get an error for the actual lookup. I don't see the doorhanger in these
> other builds.

On this system, google returns an error for the request - 400, bad request. If you want the full log with mac addresses and all that ping me on irc.

Comment 11

[:Gijs (he/him)]

Related to bug 962492?

Comment 12

[Doug Turner (:dougt)]

gijs, part of it.  that bug fixes the door hanger from showing up on some platforms.

Comment 13

[Justin Dolske [:Dolske]]

(In reply to Jim Mathies [:jimm] from comment #9)

> Correction - I get the doorhanger in my local build, but once I approve it I
> get an error for the actual lookup.

I think this is expected, unless you've configured your build to use your own Google API key (since the official keys are only provided within releng's build process for releases). [On Windows. OS X still works because we use Core Location instead of Google.]

Comment 14

[Gian-Carlo Pascutto [:gcp]]

Working again in the current official Nightly. I tried to bisect what broke/fixed this, but all my own builds seemed to work (at least, displayed the doorhanger), so I'm a bit confused.

Comment 15

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #14)
> Working again in the current official Nightly. I tried to bisect what
> broke/fixed this, but all my own builds seemed to work (at least, displayed
> the doorhanger), so I'm a bit confused.

I just tested the latest m-c win32 hourly build, and Geolocation is still not working here.  

Tested using https://bugzilla.mozilla.org/show_bug.cgi?id=970112 - No map ever appears

Comment 16

[Gian-Carlo Pascutto [:gcp]]

>No map ever appears

I get an alert with [Object Location], which is what I think it's supposed to do? Other geolocation sites works as well. (This is on Windows)

Comment 17

[Jim Mathies [:jimm]]

I installed a nightly build in a user writable folder and geo location started working again.

Comment 18

[Gian-Carlo Pascutto [:gcp]]

Okay, after some more testing: the Windows 7 machine works, the Windows 8.1 one doesn't.

Comment 19

[Jim Jeffery not reading bug-mail 1/2/11]

Still does not work here on win7 x64, today's Nightly. 

The test-case supplied here in the bug or this link do anything:

http://www.mozilla.org/en-US/firefox/geolocation/

No prompt to allow, or information is displayed.

Using the link I click in the the hyperlink:  "give it a try" 
A map opens - click the button - loading/spinning forever.  

Works in IE11.

Comment 20

[Jim Mathies [:jimm]]

This should be fixed on tomorrow's nightly.

Comment 21

[Jim Mathies [:jimm]]

Not sure if this or bug 974100 should get the status flags. Since this describes the core problem, seems fitting to track on this so we can verify this specific problem is fix on all branches.

Comment 22

[Sylvestre Ledru [:Sylvestre]]

We will track this bug to make sure the fixes get uplifted to beta & aurora.

Comment 23

[Jim Mathies [:jimm]]

Appears fixed in 2-20 nightly on Windows.

Comment 24

[svbabukumar]

Bug Triage day 24/2/2014

Validated the bug in Win 7 - 64 bit - Nightly B30, beta 28  and Aurora B29. 
I can see the alert box displaying.
Works fine for me

Comment 26

[Ada [:adalucinet]]

I was unable to reproduce this issue on 2 different Windows 7 64bit machines nor on Ubuntu 13.10 64bit with Nightly from 2014-02-09 and from 2014-02-07. With the testcase from comment 2 I see the alert box with both Firefox 28 beta 9 (Build ID: 20140306171728) and the above mentioned Nightly builds.
Am I missing something? Thanks in advance!

Comment 27

[Paul Silaghi, QA [:pauly]]

QA can't reproduce the initial issue.
Elad, Jim could you please confirm it's fixed now?

Comment 28

[Jim Mathies [:jimm]]

wfm in nightly all the way through to resolution with this test case - 
http://www.mathies.com/mozilla/geolocation.html

Comment 29

[Paul Silaghi, QA [:pauly]]

Could you please also check beta and aurora?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/28.0b9-candidates/
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/

Comment 30

[Jim Mathies [:jimm]]

(In reply to Paul Silaghi, QA [:pauly] from comment #29)
> Could you please also check beta and aurora?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/28.0b9-candidates/
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/

confirmed working for both builds on Win7 using my test case.

Comment 31

[Paul Silaghi, QA [:pauly]]

Thank you, Jim.