970119 - punctuation (?.) after newline/enter/return jumps back to the previous line (with autocorrection)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

If I have auto correction and word suggestion enabled for the keyboard (it's possible only one of these is necessary, but I didn't test), then punctuation typed on a line by itself jumps back to the end of the previous line.

Steps to reproduce:
 1. In Settings -> Keyboard -> gear icon for Built-in Keyboard, I have "Auto correction" and "Word suggestion" both turned on.  Locale is English (US).
 2. start email app and tap compose icon
 3. tap in the message body
 4. Type "hello"
 5. tap the enter/return/newline key
 6. type either "." or "?"

Actual results:  The "." or "?" jumps back to the previous line

Expected results: The "." or "?" stays on its own line.  (In general, I would expect the jumping-back behavior only for spaces that were put there by choosing a suggested word, and not for any whitespace that I type explicitly.)

I'm using a self-built build of v1.3 from last week (Tuesday, I think).

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

I'm pretty sure this has been fixed in 1.4. Could you confirm?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Nope, still broken in 1.4 -- in a master user build from last night (or was it this morning?).

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

ni?ing myself to investigate.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

We should not autopunctuate after a new line. Can't change WS regexp because it's used in other places as well.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8439898 [details] [review]
Patch

This is a valid solution to the issue that David raised here.
However, I am kind-of curious is this really an issue?

Why do we need . or ? at the the start the the next line? to type .className or .com?

You can always revert the auto-correction by pressing [Backspace] key here, and it seems a right behavior to me if you think [Enter] == [Space] and we would do this auto-punctuation for the case that the user accidentally type [Enter]/[Space] key before ".".

I'll try to get UX input on this.
Omega, could you help give some advice on this change?
Thanks.

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

No, it's completely impossible to type this in any textbox:

'A
.'

If you do 'A' 'ENTER' '.' it makes 'A. ', then press backspace makes 'A .' (no newline).

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

If that is the case, we should fix the reverting logic. :)
Agree?

Comment 8

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8439898 [details] [review]
Patch

This fix is good to me.
In this case, doing nothing is better then auto doing something wrong.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

So should we land it as-is?

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, sure, please do since this got ui-review+.
Thank you.

Comment 11

[Jan Jongboom [:janjongboom] (inactive)]

Landed https://github.com/mozilla-b2g/gaia/commit/51d57b364cee312a828b2ee1cefa909f52476f9e