Closed Bug 970162 Opened 7 years ago Closed 7 years ago

Eye watch icon not displayed in threaded view

Categories

(Thunderbird :: Theme, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 30.0

People

(Reporter: cilias, Assigned: Paenglab)

Details

Attachments

(1 file)

With the "Thread" column enabled, view a newsgroup in threaded view and press <w> to mark the thread as watched. 

The eye icon is not displayed in the thread column. Switch to unthreaded view, and the icon is displayed.

The eye icon used to be displayed in threaded view, and should be displayed in threaded view.

I've only tested this on Mac.
The earliest nightly I can find with this bug is <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/02/2013-02-26-03-05-04-comm-central/>.

The previous nightly at <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/02/2013-02-25-03-05-23-comm-central/> does not have this bug.
Attached patch patchSplinter Review
I can't test this but I suppose this should fix it. The HiDPI rules are oversteering this rules. For this I'm giving the !important flag to show this icons no matter if the line is selected or not.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8373345 - Flags: review?(josiah)
Comment on attachment 8373345 [details] [diff] [review]
patch

Review of attachment 8373345 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Unfortunately we lack a @2x icon for this, but I suppose that's out of scope here.
Attachment #8373345 - Flags: review?(josiah) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c1c20fe38337
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Thunderbird/30.0a2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.