970171 - test log image corrupt

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

$ cfx test -f tabs -b /Applications/FirefoxNightly.app/

console.log: addon-sdk: [JavaScript Error: "Image corrupt or truncated: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQImWNgYGBgAA#-moz-resolution=32,32" {file: "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQImWNgYGBgAA#-moz-resolution=32,32" line: 0}]

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: https://github.com/mozilla/addon-sdk/pull/1396

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8373124 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1396

Looks good, but we should also fix that base64 uri and test to make sure that works with tabs too. Is it the base64 that's causing it, or is that just a malformed base64 uri?

Also, I'd like to have a bit less.. competitive image for the test if this is to be eventually merged into m-c :)

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/43788026f171b6fcb2e3fe19f33af42bac4b4d0a
Bug 970171 using image from http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/Firefox.jpg in tests instead of a corrupt data: image

https://github.com/mozilla/addon-sdk/commit/acdaa7a1e9887837aa52356c8c383bcb7dc98cc4
Merge pull request #1396 from erikvold/970171

Bug 970171 remove use of corrupt image in tabs tests r=@jsantell

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8373124 [details] [review]
> https://github.com/mozilla/addon-sdk/pull/1396
> 
> Looks good, but we should also fix that base64 uri and test to make sure
> that works with tabs too. Is it the base64 that's causing it, or is that
> just a malformed base64 uri?

The test is just testing the image preview page, so any image will do.  There should be tests in Fx that the image preview page works for data: uris, regardless though that is not our responsibility.

> Also, I'd like to have a bit less.. competitive image for the test if this
> is to be eventually merged into m-c :)

This image is already in m-c, I got it from http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/Firefox.jpg