970225 - [Download Manager] Confirmation screen is displayed once for each selected file

Status: VERIFIED FIXED

Description

[rafael.marquez]

*Procedure
1. Opening Settings app
2. Opening Donwloads list (There are 2 or more files in the list)
3. Press Edit button
4. Press select all button 
5. Press Delete button

*Actual Result
Confirmation screen is displayed once for each selected file. If we have 100 files, we must confirm the removal 100 times

*Expect Result
If you select 2 or more files. Only a confirmation screen appears.

This case is not defined by UX in "DM_settingsDrawerv0.14.pdf". Please can you check this case and update the document.

Comment 1

[Cristian Rodriguez (:crdlc)]

We are going to work on it as soon as we have the wireframe, gracias Rafa

Comment 2

[Peter Dolanjski [:pdol]]

We definitely can't ship download manager without this fixed.

Francis will provide an update to clarify the expected behavior.  
Just a note, while we're blocking on this, we decided not to risk 1.4 if download manager and the child bugs aren't ready in time.  We'll evaluate that in the final sprint.

Comment 3

[Francis Djabri [:djabber]]

In the case of multiple files, a single confirmation dialog should be shown. 

Instead of showing the text: "Delete <filename>?", the confirmation should display: "Delete <n> files?", where n is the number of files selected. I'll update the spec.

Comment 4

[Cristian Rodriguez (:crdlc)]

Created attachment 8379683 [details]
16509.html

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8379683 [details]
16509.html

LGTM, tested on the phone and working perfectly.

Thanks Cristian!

Comment 6

[Cristian Rodriguez (:crdlc)]

ok, thanks a lot mate

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 8379683 [details]
16509.html

Looks good to me, too. Please check my nit on your PR.

Comment 8

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/221466ded6a14ca42fd34c1544ec17fa8549fcaa

Comment 9

[rafael.marquez]

Verified in master(1.4) branch

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 8379683 [details]
16509.html

r- from the l10n side, we'll need plural support for "delete n messages" for non-English languages for which different plural forms exist above 2.

Comment 11

[Cristian Rodriguez (:crdlc)]

(In reply to Axel Hecht [:Pike] from comment #10)
> Comment on attachment 8379683 [details]
> 16509.html
> 
> r- from the l10n side, we'll need plural support for "delete n messages" for
> non-English languages for which different plural forms exist above 2.

Fill a bug to implement it and please explain there what it is because sadly I don't have idea.

PS: Messages are always 2 or more.

Comment 12

[Axel Hecht [:Pike]]

(In reply to Cristian Rodriguez (:crdlc) from comment #11)
> Fill a bug to implement it and please explain there what it is because sadly
> I don't have idea.
> 
> PS: Messages are always 2 or more.

Filed bug 977627

Comment 13

[Fabien Cazenave [:kaze]]

OMG, I missed that. Thanks for the good catch, Pike.

Comment 14

[Fabien Cazenave [:kaze]]

(In reply to Cristian Rodriguez (:crdlc) from comment #11)
> Messages are always 2 or more.

A few locales (e.g. Arabic) have a specific plural rules for 2.
More generally, we should *always* think of a generic plural rules in such cases.

Comment 15

[Cristian Rodriguez (:crdlc)]

Now I am understand, I didn't know :( Sorry