[Download Manager] confirmation screen is displayed twice when we try remove a not supported file

VERIFIED FIXED in Firefox OS v1.4

Status

Firefox OS
Gaia::Settings
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rafael.marquez, Assigned: crdlc)

Tracking

unspecified
1.4 S2 (28feb)
Other
Other

Firefox Tracking Flags

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
*Procedure
1. Download a not supported file ".rar, .doc..."
2. Open download list
3. Tap on the file and verify that a screen "unable to open file" is displayed with the buttons "Keep file" and "Delete"
4. Press delete button and verify that a confirmation screen is displayed

*Expected Result
If we press Delete in the confirmation screen the file is deleted susccessfully.

*Actual Result
Two confirmation screens are displayed. If we press Delete in the confirmation screen, other similar confirmation screen is displayed.
(Reporter)

Updated

4 years ago
Blocks: 926955
blocking-b2g: --- → 1.4?
Whiteboard: [systemsfe]
(Assignee)

Comment 1

4 years ago
double check XDDD
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8373380 [details]
Patch v1
Attachment #8373380 - Flags: review?(kaze)
Attachment #8373380 - Flags: review?(francisco.jordano)
Comment on attachment 8373380 [details]
Patch v1

Looking great to me, thanks Cristian!
Attachment #8373380 - Flags: review?(francisco.jordano) → review+
blocking-b2g: 1.4? → 1.4+
Comment on attachment 8373380 [details]
Patch v1

LGTM, I left two suggestions on your PR.
Attachment #8373380 - Flags: review?(kaze) → review+
(Assignee)

Comment 5

4 years ago
Merged in master after addressing all comments:

https://github.com/crdlc/gaia/commit/02193445c5ae206362aad90b0bece38f4882d92b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → 1.4 S2 (28feb)
(Reporter)

Updated

4 years ago
Status: RESOLVED → VERIFIED
status-b2g-v1.4: --- → fixed
You need to log in before you can comment on or make changes to this bug.