970276 - Tab shows iframe's favicon instead of the top frame's favicon

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

I have a bugzilla tab with a TBPL iframe that shows the TBPL favicon instead of the bugzilla favicon. I noticed this first after updating to today's Nightly. I suspect this might be a regression of bug 961529. Here's a link to a bug where that is happening with the BugzillaJS add-on installed that turns TBPL links into iframes:

https://bugzilla.mozilla.org/show_bug.cgi?id=967766

It's probably not too hard to create an actual small test page to demonstrate the issue but OTOH this is probably equally easy to fix.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Testcase

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: favicon-fix

Thanks for the testcase. I really should have been more careful here. Looking at the code before my patch, it's pretty clear that the handlers for favicons, feeds, and search engines all want to ignore subframes. This patch just adds a central check.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/650fb3d50b5d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/650fb3d50b5d

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I should probably write a test for this.

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Filed bug 971336 for the test.

Comment 9

[Ekanan Ketunuti]

Verified on nightly 20140224180004 build