Closed Bug 970276 Opened 6 years ago Closed 6 years ago
Tab shows iframe's favicon instead of the top frame's favicon
I have a bugzilla tab with a TBPL iframe that shows the TBPL favicon instead of the bugzilla favicon. I noticed this first after updating to today's Nightly. I suspect this might be a regression of bug 961529. Here's a link to a bug where that is happening with the BugzillaJS add-on installed that turns TBPL links into iframes: https://bugzilla.mozilla.org/show_bug.cgi?id=967766 It's probably not too hard to create an actual small test page to demonstrate the issue but OTOH this is probably equally easy to fix.
Thanks for the testcase. I really should have been more careful here. Looking at the code before my patch, it's pretty clear that the handlers for favicons, feeds, and search engines all want to ignore subframes. This patch just adds a central check.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #8373523 - Flags: review?(felipc)
Attachment #8373523 - Flags: review?(felipc) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
I should probably write a test for this.
6 years ago
Filed bug 971336 for the test.
Verified on nightly 20140224180004 build
You need to log in before you can comment on or make changes to this bug.