970293 - Fix video tests intermittent fail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

These tests have a intermittent fail in the wait

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16132

Comment 2

[Zac C (:zac)]

Comment on attachment 8373333 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16132

Fundamentally it works but sometimes we check the thumbnailList before it is ready:




test_play_3gp_video (test_play_3gp_video.TestPlay3GPVideo)
https://moztrap.mozilla.org/manage/case/2478/ ... ERROR

======================================================================
ERROR: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zac/.virtualenvs/marionette_0_7_3/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/videoplayer/test_play_3gp_video.py", line 23, in test_play_3gp_video
    video_player.wait_for_thumbnails_to_load(10)
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/apps/videoplayer/app.py", line 28, in wait_for_thumbnails_to_load
    print self.marionette.execute_script('return window.wrappedJSObject.thumbnailList.count')
  File "/home/zac/.virtualenvs/marionette_0_7_3/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 1101, in execute_script
    filename=os.path.basename(frame[0]))
  File "/home/zac/.virtualenvs/marionette_0_7_3/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 605, in _send_message
    self._handle_error(response)
  File "/home/zac/.virtualenvs/marionette_0_7_3/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 640, in _handle_error


    raise JavascriptException(message=message, status=status, stacktrace=stacktrace)
JavascriptException: JavascriptException: TypeError: window.wrappedJSObject.thumbnailList is undefined
stacktrace:
	execute_script @app.py, line 28
	inline javascript, line 1046
	src: "let __marionetteFunc = function(){return window.wrappedJSObject.thumbnailList.count};__marionetteFunc.apply(null, __marionetteParams);"

Comment 3

[Zac C (:zac)]

Comment on attachment 8373333 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16132

this works perfectly and is neater than the last one but just one too many tab spacing there.
otherwise r+!

Comment 4

[Zac C (:zac)]

Merged!
https://github.com/mozilla-b2g/gaia/commit/ef50f0fb6ecc5d934766e2fbd56c07a33d4501e0