970301 - "mach xpcshell-test" results in "cannot import name TestResolver"

Status: RESOLVED WORKSFORME

(Firefox Build System :: Mach Core, enhancement)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

This has been happening for a few days now on OS X 10.9 and can't be fixed by clobbering:

past@deck:fx-team$ ./mach xpcshell-test 
From _tests: Kept 12782 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['xpcshell-test']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: cannot import name TestResolver

  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 333, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 61, in run_test
    from mozbuild.testing import TestResolver

Comment 1

[Gregory Szorc [:gps]]

Delete your python/mozbuild/mozbuild/testing directory (which likely only contains some .pyc files that are ignored by version control).

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Progress!

past@deck:fx-team$ rm -rf python/mozbuild/mozbuild/testing
past@deck:fx-team$ mach xpcshell-test toolkit/devtools/
From _tests: Kept 12782 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['xpcshell-test', 'toolkit/devtools/']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ParseError: could not parse: (os == "win" || "linux" || "mac"); variables: {}

  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 333, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 102, in run_test
    return self._run_xpcshell_harness(**args)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 124, in _run_xpcshell_harness
    verbose_output = test_path is not None or (manifest and len(manifest.test_paths())==1)
  File "/Users/past/src/fx-team/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py", line 1102, in test_paths
    return [test['path'] for test in self.active_tests()]
  File "/Users/past/src/fx-team/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py", line 1091, in active_tests
    self.filter(values, tests)
  File "/Users/past/src/fx-team/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py", line 1060, in filter
    if parse(condition, **values):
  File "/Users/past/src/fx-team/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py", line 279, in parse
    return ExpressionParser(text, values, strict=True).parse()
  File "/Users/past/src/fx-team/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py", line 266, in parse
    raise ParseError("could not parse: %s; variables: %s" % (self.text, self.valuemapping))

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Without specifying a directory:

past@deck:fx-team$ mach xpcshell-test 
From _tests: Kept 12782 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['xpcshell-test']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'unicode' object has no attribute 'test_paths'

  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 333, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 74, in run_test
    rerun_failures=rerun_failures)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 52, in run_suite
    return self._run_xpcshell_harness(manifest=manifest, **kwargs)
  File "/Users/past/src/fx-team/testing/xpcshell/mach_commands.py", line 124, in _run_xpcshell_harness
    verbose_output = test_path is not None or (manifest and len(manifest.test_paths())==1)

Comment 4

[Gregory Szorc [:gps]]

The other issues are due to bug 956474 or bug 970302.