970302 - 'mach xpcshell-test' results in AttributeError: 'unicode' object has no attribute 'test_paths'

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Started getting this today on fx-team tip (Ubuntu 13.10):

past@holo:fx-team$ ./mach xpcshell-test
From _tests: Kept 12805 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['xpcshell-test']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'unicode' object has no attribute 'test_paths'

  File "/home/past/src/fx-team/testing/xpcshell/mach_commands.py", line 333, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/home/past/src/fx-team/testing/xpcshell/mach_commands.py", line 74, in run_test
    rerun_failures=rerun_failures)
  File "/home/past/src/fx-team/testing/xpcshell/mach_commands.py", line 52, in run_suite
    return self._run_xpcshell_harness(manifest=manifest, **kwargs)
  File "/home/past/src/fx-team/testing/xpcshell/mach_commands.py", line 124, in _run_xpcshell_harness
    verbose_output = test_path is not None or (manifest and len(manifest.test_paths())==1)

Comment 1

[Gregory Szorc [:gps]]

Why is "manifest" a unicode? That's really weird.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

        manifest = os.path.join(self.topobjdir, '_tests', 'xpcshell',
            'xpcshell.ini')

        return self._run_xpcshell_harness(manifest=manifest, **kwargs)

Comment 3

[Gregory Szorc [:gps]]

Attachment: Ensure a TestManifest is always used when running xpcshell tests

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/881a08901c0d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/881a08901c0d