970320 - [Cost Control] Add configuration to provide top-up & check balance in Movistar Uruguay

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marcelino Veiga Tuimil [:sonmarce]]

This is just to add new configuration in order to provide Cost Control to Movistar Uruguay according to their network characteristics:
* Operator short name: 'movistar'
* Balance SMS in OB territory is always free: true
* Balance SMS in roaming is always free: true
* Country currency symbol for display: '$'
* Number to send balance SMS to: '222'
* Text to be sent in SMS body: 'SALDO' (any text is valid, even blank)
* List of possible numbers the balance response SMS may come from: ['222']
* Format of the balance SMS response: 'Saldo:$xxx' (should take any number, including decimals)
* Format of the balance SMS response when the user has reached zero balance: 'Saldo:$0' (should be same format as balance)
* Required time between two automatic balance enquiries: 3 hours
* Number to dial for USSD top-up: '*222*1*1#'  
* SMS-based top-up: disabled
* Amount in local currency that triggers low balance alarm: 0 (operator already sends an SMS in case of low balance, so we could skip notification)

It does not require implementation, just adding a new configuration for the MCC/MNC

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Added config file for movistar Uruguay

Comment 2

[Marina Rodríguez [:mai]]

Comment on attachment 8373359 [details] [review]
patch v1.0

Salva, please, could you review the code?

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8373359 [details] [review]
patch v1.0

According to the specification provided by Uruguay, all is ok. It would be great if we are gien some testing SIMs to verify. Thank you.

Comment 4

[Salvador de la Puente González [:salva]]

Marina, can you publish the last specification for balance SMSs and update what Marce is saying in c#0?

Comment 5

[Marina Rodríguez [:mai]]

* Operator short name: 'Movistar'
* Balance SMS in OB territory is always free: true
* Balance SMS in roaming is always free: true
* Country currency symbol for display: '$'
* Number to send balance SMS to: '222'
* Text to be sent in SMS body: 'SALDO' (any text is valid, even blank)
* List of possible numbers the balance response SMS may come from: ['222']
* Format of the balance SMS response: 'Recarga $ x.xx' (should take any number, including decimals)
* Format of the balance SMS response when the user has reached zero balance: 'Su saldo actual es cero'
* Required time between two automatic balance enquiries: 3 hours
* Number to dial for USSD top-up: '*222*1*1#'  
* SMS-based top-up: disabled


Example of sms:
"Recarga $ 2.43 vto 21/2
Paquete  Navegacion WAP/WEB/UMT-27.7 MB vto 01/03/13"

Comment 6

[Marina Rodríguez [:mai]]

Uruguay configuration: 
* Operator short name: 'Movistar'
* Balance SMS in OB territory is always free: true
* Balance SMS in roaming is always free: true
* Country currency symbol for display: '$'
* Number to send balance SMS to: '222'
* Text to be sent in SMS body: 'SALDO' (any text is valid, even blank)
* List of possible numbers the balance response SMS may come from: ['222']
* Format of the balance SMS response: 'Recarga $x.xx' or 'Recarga $xxx' (should take any number, including decimals)
* Format of the balance SMS response when the user has reached zero balance: 'Su saldo actual es cero'
* Required time between two automatic balance enquiries: 3 hours
* Number to dial for USSD top-up: '*222*1*1#'  
* SMS-based top-up: disabled


sms samples:
 *  "Recarga $75 vto 12/3 Tenes Movistar, tenes beneficios exclusivos: Recargando 200 pesos o mas hablas por pesos 0.99 iva inc el minuto a todos los Movistar y telefonos fijos del pais a toda hora y la recarga te dura hasta 60 dias. Promo valida recargando desde el 13/1/2014 al 15/2/2014."

 *  "Recarga $72.99 vto 12/3 Tenes Movistar, tenes beneficios exclusivos: Recargando 200 pesos o mas hablas por pesos 0.99 iva inc el minuto a todos los Movistar y telefonos fijos del pais a toda hora y la recarga te dura hasta 60 dias. Promo valida recargando desde el 13/1/2014 al 15/2/2014"

Comment 7

[Marina Rodríguez [:mai]]

Master: a5099dd1cc3e6761022b979bb58d2d29744a61d8

Comment 8

[Marcelino Veiga Tuimil [:sonmarce]]

Asking for 1.3, as it is required for Movistar Uruguay, there should be almost no risk as it only adds configuration for the operator, and it will enable operator users to check balance & top-up

Comment 9

[Salvador de la Puente González [:salva]]

We prefer to provide a better and more error-proof regular expression.

Back-out: e91e76f5a451b61bdf9be18b012a242dfe72fb05

Comment 10

[Salvador de la Puente González [:salva]]

Marina, please, ask for my review again once you replace the regular expression.

Comment 11

[Marina Rodríguez [:mai]]

Attachment: pat v1.1

Please Salva, could yout test the new patch ?

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 8374106 [details] [review]
pat v1.1

Cool! Less restrictive now but reasonable. Than you Mai!

Comment 13

[Marina Rodríguez [:mai]]

Master: 4b928371c9c58a484ae76a73c9f88a39a755a031

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ for a target release

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 4b928371c9c58a484ae76a73c9f88a39a755a031 to:
v1.3: 39c0727e66a2f8d5b344f32816929ff2099a903d