970395 - Send email notice to Mentor when a mentee is inactive for a certain period

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Now that we have a new reporting system that does not depend on months, we need an email that is sent to an individual Mentor when one of their mentees is inactive for a certain period. Then the Mentor can encourage the Rep to take action, and to file a report.

The specs for this -- what constitutes inactivity, and for how long -- are in bug 967026.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/83217ab81eb081d96400aa702fc074bdfd4d9d36
[fix bug 970395] Send a mentor notification when the mentee is inactive.

https://github.com/mozilla/remo/commit/e9bd5e6b35d2a0e7f5007642069f684eddf88c76
Merge pull request #647 from akatsoulas/970395

[fix bug 970395] Send a mentor notification when the mentee is inactive.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Verified on stage. As a mentor I get an email when a mentee of mine doesn't have reports with report_date between 3 weeks in the past and 3 weeks in the future from now.

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

I'm reopening this bug since it is dependent on conversation happening in bug 984573. We're building a UI that allows mentors to see which reps have not had much activity in recent weeks, and that is almost certain to change the specs about when emails will go out. We'll add those specs here when it's clear.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

We have code to email mentors when their reps haven't been active, but the specs for that feature have changed slightly.

* activity is anything that would cause a report to be filed
* the date to be used for measuring activity is the date the activity happened, not the date the report was filed
* we will email mentors anytime they have a rep who has no activity ...
  ** in the past 8 weeks or in the next 8 weeks
  ** in the past 4 weeks or in the next 4 weeks and who didn't already get an email for 8 weeks

Examples:
* Susie has not had any activity for 4 weeks and has none in the future. She and her mentor will get an email.
* Joe has not had any activity for 7 weeks, and has none in the future. He and his mentor got an email when he had no activity after 4 weeks. He and his mentor will get another email in a week unless he has some activity.
* Hamburglar has not had any activity for six months. He and his mentor got an email after 4 weeks went by with no activity, and another after 8 weeks went by with no activity. They had a good long talk over lunch one day. Three months ago, Hamburglar created an event that will happen in 10 days. Hamburglar and his mentor received 2 emails total about activity. 
* Hamburglar's event was great! But after the event, Hamburglar got very busy at work. 4 weeks went by without another activity. Hamburglar and his mentor got an email. If Hamburglar still hasn't created an activity in 4 more weeks, he and his mentor will get another email 4 weeks from now.

Comment 5

[Tasos Katsoulas [:tasos]]

Stage server sends out multiple notifications. One each day. By checking the admin panel, the "first_report_notification" field in the user profile is not saved with the date of the notification.

Comment 6

[Tasos Katsoulas [:tasos]]

Fixed by this commit:

https://github.com/mozilla/remo/commit/fa71a6904e09cf4c284464682663d36b9ec80f46

Comment 7

[Tasos Katsoulas [:tasos]]

Verified on stage.