Closed Bug 970460 Opened 10 years ago Closed 10 years ago

the noscript-element breaks the facebook scraper

Categories

(developer.mozilla.org Graveyard :: Design, defect)

Product:
developer.mozilla.org Graveyard
Component:
Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: icaaq, Unassigned)

Details

if you validate the open graph data on the add-on zone page, https://developers.facebook.com/tools/debug/og/object?q=https%3A%2F%2Fdeveloper.mozilla.org%2Fen-US%2FAdd-ons you will see that the validator says: Meta Tags In Body, Your page has meta tags in the body instead of the head. This may be because your HTML was malformed and they fell lower in the parse tree.
Please fix this in order for the tags to be usable.

This is because of the noscript-element.

I can see two solutions:
1. move the noscript-element to be the last-child of <head>
2. use a no-js class on html and remove the noscript-element.
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/416173318982ce8d69b25d23f3c695c3e17ac081
fix bug 970460 - Move noscript to avoid FB problem

https://github.com/mozilla/kuma/commit/d3e144ab02e4fff42ddeb269fd494db2f9a4ddb4
Merge pull request #1989 from darkwing/facebook-970460

fix bug 970460 - Move noscript to avoid FB problem
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.