970485 - `CustomizableUI.getWidget(id).forWindow(window).anchor` sometimes raise an exception.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matteo Ferretti [:zer0] [:matteo]]

In some cases, `CustomizableUI.getWidget(domNode.id).forWindow(window).anchor` raises a "`aWidget` is not defined" exception.

To be more precise, asking for the anchor in this code is always working:

https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/widget.js#L456

Where if I try to move that part of code here:

https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/panel/utils.js#L136

is failing all the time. The problem seems the getter of `anchor` property.

Comment 1

[:Gijs (he/him)]

Is CUI.getWidget(id).forWindow(window).node null, by any chance?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

No, the `node` returns the same `domNode` where we get the id:

    console.log(CUI.getWidget(domNode.id).forWindow(window).node === domNode) // true
    console.log(CUI.getWidget(domNode.id).forWindow(window).anchor) // ReferenceError: aWidgetId is not defined

Comment 3

[:Gijs (he/him)]

Attachment: Australis widget wrapper's anchor property for API-provided widgets causes exceptions,

Well, that is embarrassing...

Comment 4

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/4eb2df686edc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4eb2df686edc

Comment 6

[:Gijs (he/him)]

Comment on attachment 8374184 [details] [diff] [review]
Australis widget wrapper's anchor property for API-provided widgets causes exceptions,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: add-on APIs don't work correctly
Testing completed (on m-c, etc.): local, on m-c
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fc402a7182ef